Fix clipping of the tile layer extent on HiDPI devices #5724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahocevar
force-pushed
the
fix-tilelayer-extent
branch
from
048aedb to
aabe621
Compare
Member
|
Will this fixes the ipad issues related to the maximum canvas size? |
Member
Author
|
@fredj It will at least improve the situation there, because the canvas size during rotation will be much smaller after this change. |
Member
|
code LGTM |
Member
Author
|
Thanks for the review. I'm adding some tests now to make sure we don't get more regressions like this later on. |
The goal of using a drawScale was to use the smallest possible canvas (i.e. one that fits the tile pixel ratio instead of the view pixel ratio) when composing rotated views. Instead, the drawScale caused a ridiculously large canvas.
ahocevar
force-pushed
the
fix-tilelayer-extent
branch
from
aabe621 to
d333df0
Compare
ahocevar
force-pushed
the
fix-tilelayer-extent
branch
from
d333df0 to
208ea17
Compare
Member
|
LGTM thanks for adding all the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the fix for layer clipping on HiDPI devices, this pull request also fixes the drawScale calculation. The drawScale has caused us to create ridiculously large canvases when rotating on HiDPI devices, so this pull request also fixes the performance problem reported in #5683.
Fixes #5716.
Fixes #5683.