Allow CanvasPattern or CanvasGradient as stroke style #5863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredj
force-pushed
the
stroke_pattern
branch
from
9c75ff5 to
989e4aa
Compare
fredj
changed the title
Member
Author
|
Rendering tests added, thanks for any review |
fredj
force-pushed
the
stroke_pattern
branch
from
989e4aa to
d7dc440
Compare
src/ol/style/stroke.js
Outdated
| this.checksum_ = 's'; | ||
| if (this.color_) { | ||
| if (typeof this.color_ === 'string') { | ||
| this.checksum_ += ol.color.asString(this.color_); |
Member
There was a problem hiding this comment.
this.color_ is a string already, so no need to call ol.color.asString().
fredj
force-pushed
the
stroke_pattern
branch
from
d7dc440 to
c6396ce
Compare
|
How can I include this code into ol.js? I have only ol.js (the latest version). Where can I find some instructions? |
fredj
force-pushed
the
stroke_pattern
branch
from
c6396ce to
e48fda6
Compare
Member
|
Looks good now. Please merge. |
Member
Author
|
Thanks for the review @ahocevar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5865