Skip to content

Conversation

@tschaub
Copy link
Member

@tschaub tschaub commented Feb 9, 2018

There is no need to tack additional unused properties onto our constructors.

See #7802.

@tschaub tschaub mentioned this pull request Feb 9, 2018
49 tasks
@tschaub tschaub changed the title Remove private static members from constructors WIP: Remove private static members from constructors Feb 10, 2018
Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, please merge when Travis is happy. Looks like the failing tests are related.

@tschaub tschaub changed the title WIP: Remove private static members from constructors Remove private static members from constructors Feb 10, 2018
@tschaub tschaub merged commit ec30c89 into openlayers:master Feb 10, 2018
@tschaub tschaub deleted the unstatic-private branch February 10, 2018 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants