Skip to content

Conversation

@ahocevar
Copy link
Member

@ahocevar ahocevar commented Jul 7, 2018

This pull request simplifies geometry construction and improves performance by avoiding a change event upon construction.

After this change, geometry constructors accept flat coordinates, but no longer accept null as coordinates.

Replaces #8353.

Copy link
Member

@tonio tonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ahocevar for tackling this so quickly!
(unrelated, looks that I lost my commit rights at some time…)

@ahocevar
Copy link
Member Author

ahocevar commented Jul 9, 2018

Thanks for the review @tonio. I have restored your commit rights.

@ahocevar ahocevar merged commit d0a8043 into openlayers:master Jul 9, 2018
@ahocevar ahocevar deleted the smart-flat-coordinates branch July 9, 2018 08:27
@tonio
Copy link
Member

tonio commented Jul 9, 2018

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants