-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Uncouple replay creation and rendering #8926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
482c04b to
2255149
Compare
c9abff7 to
8c300a6
Compare
e4fe204 to
8303281
Compare
|
@ahocevar, the creation of text instructions is now fully separated from the executor. I will work on removing the creation of images from the styles in a different PR as it is not necessary until we have workers and I am eager to see this PR merged. |
76ecf7f to
d7df45f
Compare
Signed-off-by: Guillaume Beraudo <guillaume.beraudo@camptocamp.com>
Executors are use to render instructions. They do not contain cod for building instructions. Signed-off-by: Guillaume Beraudo <guillaume.beraudo@camptocamp.com>
d7df45f to
f9dcadb
Compare
|
@ahocevar, the PR is now ready for review. |
5fe55e5 to
60642ca
Compare
60642ca to
da92b2a
Compare
|
@ahocevar, I fixed the pixelratio issue, improved the test and fixed the mismatching executor/builder types. I also simplified the names: Executor, Builder, ExecutorGroup, BuilderGroup. That is shorter to type and easier to remember. The last point left is passing all states in the instructions which I will tackle tomorrow. |
ahocevar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks for this! I added a FIXME about not creating the measure function with every execute() call. That can be addressed in a follow-up pull request.
The goal of this PR is to split the replays in 2 parts:
Plan is:
Postponed to a later phase: