feat: template delimiter config #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…delims and cleanup template On-behalf-of: Radek Schekalla (SAP) <radek.schekalla@sap.com> Signed-off-by: Radek Schekalla (SAP) <radek.schekalla@sap.com>
On-behalf-of: Radek Schekalla (SAP) <radek.schekalla@sap.com> Signed-off-by: Radek Schekalla (SAP) <radek.schekalla@sap.com>
On-behalf-of: Radek Schekalla (SAP) <radek.schekalla@sap.com> Signed-off-by: Radek Schekalla (SAP) <radek.schekalla@sap.com>
reshnm
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR allows to configure delimiters used by the go template in bootstrapper on individual file level:
#?bootstrap {"template": {"delims": {"start": "<<", "end": ">>"}}}A detected delim config is parsed and applied for the templating run of the respective template
After detection and application, the delim config comment is removed from the template for further processing
Background:
The bootstrapper uses go templating to create needed manifests in order so setup openmcp landscapes. Additionally, users can add own manifests (i.e. extra-manifests) that the bootstrapper will pick up and put into the gitops structure. The bootstrapper is moving these through its templating, too. However, these manifests can contain own go template syntax (e.g. eso external secret templates) meant to be templated in their own context rather than by the bootstrapper. To avoid such conflicts, we introduce a way to tell the bootstrapper templating which templates to handle, based on the delimiters used on individual file level.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: