fix: generate changelog generation for first time repos #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xed pr_commits fetching, so support empty git logs
n3rdc4ptn
requested review from
Copilot and
moelsayed
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the changelog generator to support repositories without any existing release tags and prevents failures when no PR numbers are found in commit messages.
- Use an empty-string check instead of a file-existence test to detect the first release
- Add
|| trueto thePR_COMMITSpipeline to avoid script errors on empty results
Comments suppressed due to low confidence (2)
generate-changelog.sh:14
- [nitpick] The comment
# first release?is ambiguous; consider clarifying it to indicate that this branch handles the case when no release tag was found.
if [[ -z "$LATEST_RELEASE_TAG" ]]; then # first release?
generate-changelog.sh:14
- Add a test case for repositories with no existing release tags to verify that
generate-changelog.shcorrectly falls back to the initial commit.
if [[ -z "$LATEST_RELEASE_TAG" ]]; then # first release?
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
n3rdc4ptn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fixes generate-changelog for fresh started repos.