Skip to content

Conversation

@moelsayed
Copy link
Contributor

Update README

add release action

clean up Makefile

update chart and chart template

remove golangci action

add ci action

remove unused config

rename module

initial merge from cloud-orchestration/control-plane-operator

    Update README

    add release action

    clean up Makefile

    update chart and chart template

    remove golangci action

    add ci action

    remove unused config

    rename module

    initial merge from cloud-orchestration/control-plane-operator
Comment on lines +13 to +33
runs-on: ubuntu-24.04

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Set up Go
uses: actions/setup-go@v5
with:
go-version-file: go.mod

- name: make tidy
run: |
make tidy
git diff --exit-code

- name: make verify
run: make verify

- name: make test
run: make test No newline at end of file

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
replicaCount: 1

image:
repository: ghcr.io/openmcp-project/github.com/openmcp-project/control-plane-operator/images/control-plane-operator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moelsayed FYI: I already changed the repository in the values here. This should work, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I left this to be updated in a follow up PR where I will add the publish action. But it's ok to have it updated now.

Copy link
Member

@maximiliantech maximiliantech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maximiliantech maximiliantech merged commit 13319da into main Mar 13, 2025
5 checks passed
@maximiliantech maximiliantech deleted the merge_branch branch March 13, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants