-
Notifications
You must be signed in to change notification settings - Fork 2
Adding code from cloud-orchestration/control-plane-operator #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
moelsayed
commented
Mar 12, 2025
Update README
add release action
clean up Makefile
update chart and chart template
remove golangci action
add ci action
remove unused config
rename module
initial merge from cloud-orchestration/control-plane-operator
| runs-on: ubuntu-24.04 | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version-file: go.mod | ||
|
|
||
| - name: make tidy | ||
| run: | | ||
| make tidy | ||
| git diff --exit-code | ||
|
|
||
| - name: make verify | ||
| run: make verify | ||
|
|
||
| - name: make test | ||
| run: make test No newline at end of file |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
| replicaCount: 1 | ||
|
|
||
| image: | ||
| repository: ghcr.io/openmcp-project/github.com/openmcp-project/control-plane-operator/images/control-plane-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moelsayed FYI: I already changed the repository in the values here. This should work, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I left this to be updated in a follow up PR where I will add the publish action. But it's ok to have it updated now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM