-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add jsonpatch library #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I swapped the |
|
OK, let me quickly evaluate using the kustomize type. |
|
I replaced our own json patch api type implementation with the kustomize one. I still kept the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for taking the extra time to validate the suggestions 🙏
|
@Diaphteiros Since you've made some adjustments in the codebase after the initial review by @ValentinGerlach, could you please update the PR description if necessary 🙏 |
What this PR does / why we need it:
For the Gardener ClusterProvider, we want to be able to overwrite arbitrary fields of the generated shoot manifest via a ClusterConfig resource. An easy solution for this is by using JSON patches to describe the desired changes to the shoot manifest.
Since this functionality could be useful in further scenarios, I implemented it in the controller-utils library.
Which issue(s) this PR fixes:
Related to openmcp-project/backlog#12
Special notes for your reviewer:
Release note: