improve the advanced clusteraccess library's abilities to mock fake clients in unit tests #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lients in unit tests
Diaphteiros
requested review from
ValentinGerlach,
maximiliantech and
robertgraeff
robertgraeff
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
While trying to use the advanced clusteraccess library in the PlatformService DNS, I noticed some shortcomings regarding unit tests. This PR fixes that.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Release note:
The advanced ClusterAccess library's capabilities regarding unit tests have been enhanced by adding a configurable `FakeClientGenerator` to the reconciler. If set, this function will be called when trying to build a `client.Client` out of an `AccessRequest`'s kubeconfig secret. This enables the test code to inject fake client implementations into the reconciler's `Access` method and thereby removes the need for any test-specific coding in the controller's logic itself.