fix: dont fail when the platform namespace exists without the desired labels #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertgraeff
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The platform service mcp would fail when the platform cluster namespace already exists, but doesn't have the correct labels. This could happen if a service provider using the clusteraccess lib would create the namespace firts.
Now instead of failing, only the desired labels are set when the namespace already exists.
This might not be the final solution, but should work for now.
A cleaner solution would maybe require an update to the clusteraccess lib.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: