feat: external-dns cluster controller #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The label selector is incompatible with the current implementation that loads the config on-demand during each reconciliation. We would either need to load it once during startup, which would mean that the controller needs to be restarted for changes to take effect, or we would need a more complicated setup with an own controller for the config. Since clusters can already be filtered by their purposes, there is probably no need for a label selector anyway, at least not for now.
Diaphteiros
requested review from
ValentinGerlach,
maximiliantech,
reshnm and
robertgraeff
reshnm
reviewed
Sep 24, 2025
reshnm
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Finishes the implementation of the controller that reconciles
Clusterresources and deploysexternal-dnson them if their purposes match.Which issue(s) this PR fixes:
Main part of openmcp-project/backlog#95
Special notes for your reviewer:
Release note: