chore: remove unused packages #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaskienle
requested changes
Mar 25, 2025
There was a problem hiding this comment.
I think you removed a bit too much.
Technically it would work because the “missing” dependencies are referenced by other dependencies, but we should not rely on this. For example, clsx ist installed indirectly because it’s also used by @ui5/webcomponents-react, or javascript-time-ago is referenced by react-time-ago and so on. But this is an implementation detail that could change.
We should explicitly state and document our dependencies.
|
Great spot, thank you Andreas. I fully agree, we should explicitly mention our dependencies. I did not think of them being indirectly referenced when I remove them and the build and test were successful. I changed according to your feedback, please recheck 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We had some leftover dependencies from earlier prototype version that we dont use anymore. This PR removes them.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: