Skip to content

Conversation

Lasserich
Copy link
Contributor

@Lasserich Lasserich commented Aug 20, 2025

What this PR does / why we need it:

The current MCP page seems a bit empty with no clear guidance on what is going strong or wrong. This feature adds so called hints which are stats on your MCP, including overall managed resource health, GitOps state and soon to be external-secrets state.

After
image

Before
image

Related

Further

  •  Make only one getAllManagedResources call instead of having one call in the table, graph & hints
  •  Currently language is not properly implemented
  • Currently the external secret does not display any stat yet
  • Make stats more sophisticated (e.g. How many resources are healthy/creating etc.?)

@Lasserich Lasserich requested a review from lucasgoral August 20, 2025 17:07
@Lasserich
Copy link
Contributor Author

Do you know the issue with forbidden package origin from the pipeline? @lucasgoral @Hubert-Szczepanski-SAP

maxWidth: '1280px',
margin: '0 auto',

// This breaks the scrolling currently since its zIndex is higher than the header bar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried to adjust the zIndex to lower one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did play around a little but I do also like the current approach of it taking space instead of layering over the chart. Is this also fine for you?

@lucasgoral
Copy link
Contributor

image We should't have an button that is blue (active) but has no action assigned. Maybe you can disable it?

@Lasserich
Copy link
Contributor Author

image We should't have an button that is blue (active) but has no action assigned. Maybe you can disable it?

I think you are still on an old branch, please take a look at the PR header. Is this more what you envisioned? Goal from my side is to nudge the user to take a look at why this component is disabled, and then get to our docs explaining the benefits of this component and how to enable it. WDYT?

@lucasgoral lucasgoral merged commit 146de6b into openmcp-project:main Aug 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants