Provider Configs Table #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hubert-Szczepanski-SAP
force-pushed
the
feature/providers-configs-table
branch
from
4e9cc78 to
3924a60
Compare
src/lib/api/useApiResource.ts
Outdated
|
|
||
| const providerConfigsData: ProviderConfigsData[] = crdWithProviderConfig?.map((item) => { | ||
| return { | ||
| provider: item.metadata.name, |
There was a problem hiding this comment.
Would it be possible to get the providers name in clear text?
There was a problem hiding this comment.
Fixed! :) Changes already pushed
lucasgoral
previously approved these changes
Apr 2, 2025
src/lib/api/useApiResource.ts
Outdated
| }); | ||
| } | ||
|
|
||
| providerConfigsDataForRequest.forEach(async (item) => { |
There was a problem hiding this comment.
The forEach method doesn't handle asynchronous operations properly because it doesn't wait for the promises to resolve before moving on.
You can use something like this:
const promises = providerConfigsDataForRequest.map(async (item) => {
const data = await fetchApiServerJson<ProviderConfigs>(
`/apis/${item.url ?? ''}/${item.version}/providerconfigs`,
apiConfig,
CRDRequest.jq,
CRDRequest.method,
CRDRequest.body
);
if (data) {
providerConfigs.push(data);
}
});
await Promise.all(promises);
| providerConfigsList.forEach((provider) => { | ||
| provider.items.forEach((config) => { | ||
| rows.push({ | ||
| parent: provider.provider, |
There was a problem hiding this comment.
You sure that you can access this object properties without Optional chaining (?.) operator?
Hubert-Szczepanski-SAP
force-pushed
the
feature/providers-configs-table
branch
from
bda676c to
ae274c8
Compare
providers config table
Moving function to common file
Hubert-Szczepanski-SAP
force-pushed
the
feature/providers-configs-table
branch
from
ae274c8 to
1789a22
Compare
lucasgoral
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providers config table with temporary solution for getting configs. There are a lot of requests to be made. They are made async.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: