Skip to content

Conversation

andreaskienle
Copy link
Contributor

@andreaskienle andreaskienle commented Sep 24, 2025

@andreaskienle andreaskienle marked this pull request as ready for review September 24, 2025 09:28
@Copilot Copilot AI review requested due to automatic review settings September 24, 2025 09:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the application's login interface by replacing the old LoginView component with a new SignInPage component and changing the logo imagery to support both light and dark themes.

  • Replaces the legacy LoginView with a modernized SignInPage component using CSS modules
  • Implements theme-aware logo display with separate light and dark variants
  • Updates localization keys and messaging to reflect the new branding

Reviewed Changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/views/login.css Removes the old CSS file for the LoginView component
src/views/Login.tsx Removes the deprecated LoginView component
src/spaces/onboarding/pages/SignInPage/SignInPage.tsx Adds new SignInPage component with theme-aware logo support
src/spaces/onboarding/pages/SignInPage/SignInPage.module.css Adds CSS modules styling for the new SignInPage component
src/App.tsx Updates import and usage from LoginView to SignInPage
public/locales/en.json Updates localization keys and messaging for the new SignInPage

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@andreaskienle andreaskienle marked this pull request as draft September 24, 2025 09:29
@andreaskienle andreaskienle marked this pull request as ready for review September 24, 2025 11:50
Copy link
Contributor

@Hubert-Szczepanski-SAP Hubert-Szczepanski-SAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks nice, especially in the dark mode

@andreaskienle andreaskienle merged commit 7f455c6 into main Sep 29, 2025
5 checks passed
@andreaskienle andreaskienle deleted the ft/logo branch September 29, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants