feat: show MCP metadata in the header #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a header component to the MCP (Managed Control Plane) page displaying metadata information including name, creation date, and creator.
- Creates a new
McpHeadercomponent that displays MCP metadata in a grid layout - Integrates the header component into the existing MCP page using
ObjectPageHeader - Updates the API type definition to include
creationTimestampand optional creator annotation
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/spaces/mcp/pages/McpPage.tsx | Integrates the new McpHeader component into the ObjectPage headerArea |
| src/spaces/mcp/components/McpHeader.tsx | Creates the header component displaying MCP name, creation date, and creator |
| src/spaces/mcp/components/McpHeader.module.css | Defines CSS styles for the header's grid layout and label styling |
| src/spaces/mcp/components/McpHeader.cy.tsx | Adds Cypress tests for the header component functionality |
| src/lib/api/types/crate/controlPlanes.ts | Updates type definitions and API query to include creationTimestamp and optional created-by annotation |
| public/locales/en.json | Adds English translations for the header labels |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Hubert-Szczepanski-SAP
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements openmcp-project/backlog#284
The backlog item says to show the display name. With the previous changes, we already show this name as the main title, so I added the k8s resource name statically to the header instead.