feat: hide tabs of uninstalled components #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements conditional rendering to hide tabs of uninstalled components in the MCP page, addressing the requirement to only show tabs for components that are actually installed.
- Adds component installation checks for crossplane, flux, and landscaper
- Wraps ObjectPageSection components with conditional rendering based on installation status
- Updates the ControlPlaneComponentsType interface to include the landscaper component
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/spaces/mcp/pages/McpPage.tsx | Added component installation checks and conditional rendering for crossplane, flux, and landscaper sections |
| src/lib/api/types/crate/controlPlanes.ts | Added landscaper component to the ControlPlaneComponentsType interface |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements openmcp-project/backlog#293