fix: add not-pending prCreation for not waiting for status checks #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaskienle
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Renovate was not creating PRs for the @ui5/webcomponents package group (and potentially other updates). The branch renovate/@ui5webcomponents-packages exists but remains in "pending" state without an associated PR.
Root cause: The default config:recommended preset uses prCreation: "approval", which waits for CI checks to run on the branch before creating a PR. Since our CI is configured to run on PRs (not on branches), Renovate waits indefinitely for test results that never come.
Solution
Add "prCreation": "not-pending" to the Renovate configuration. This tells Renovate to create PRs immediately once the branch is ready, without waiting for CI checks on the branch itself.
Changes
Added "prCreation": "not-pending" to .github/renovate.json
Impact
PRs will be created immediately for all dependency updates
CI checks will still run on the PRs as usual
No more stuck branches waiting for non-existent CI runs
The existing renovate/@ui5webcomponents-packages branch will get its PR on the next Renovate run
Testing
After merging, the next Renovate run should create the missing UI5 PR.