-
Notifications
You must be signed in to change notification settings - Fork 3
Add rollup functionality to CLIP Detection component #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ZachCafego)
python/ClipDetection/clip_component/clip_component.py
line 31 at r2 (raw file):
import csv from pkg_resources import resource_filename from typing import Iterable, Mapping, TypedDict
VScode says Iterable and TypedDict are not used.
python/ClipDetection/clip_component/clip_component.py
line 90 at r2 (raw file):
self._triton_server_url = None def get_classifications(self, images, job_properties: Mapping[str, str]) -> mpf.ImageLocation:
This should be -> Iterable[mpf.ImageLocation]:
python/ClipDetection/clip_component/clip_component.py
line 95 at r2 (raw file):
self._check_class_list(kwargs['classification_path'], kwargs['classification_list']) self._preprocessor = ImagePreprocessor(kwargs['enable_cropping'])
Do the following in __init__
:
self._preprocessor = None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @ZachCafego)
python/ClipDetection/clip_component/clip_component.py
line 69 at r2 (raw file):
except Exception as e: logger.exception(f"Failed to complete job {image_job.job_name} due to the following exception:")
Components developed more recently do:
except Exception as e:
logger.exception(f'Job failed due to: {e}')
raise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 4 unresolved discussions (waiting on @jrobble)
python/ClipDetection/clip_component/clip_component.py
line 31 at r2 (raw file):
Previously, jrobble (Jeff Robble) wrote…
VScode says Iterable and TypedDict are not used.
Done.
python/ClipDetection/clip_component/clip_component.py
line 69 at r2 (raw file):
Previously, jrobble (Jeff Robble) wrote…
Components developed more recently do:
except Exception as e: logger.exception(f'Job failed due to: {e}') raise
Done.
python/ClipDetection/clip_component/clip_component.py
line 90 at r2 (raw file):
Previously, jrobble (Jeff Robble) wrote…
This should be
-> Iterable[mpf.ImageLocation]:
Done.
python/ClipDetection/clip_component/clip_component.py
line 95 at r2 (raw file):
Previously, jrobble (Jeff Robble) wrote…
Do the following in
__init__
:self._preprocessor = None
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ZachCafego)
Issues:
This change is