Skip to content

Conversation

@jrobble jrobble self-requested a review January 8, 2024 17:43
@jrobble
Copy link
Member

jrobble commented Jan 8, 2024

cpp/KeywordTagging/Dockerfile line 36 at r6 (raw file):

ENV LC_ALL C.UTF-8

#mitre cert...

Remove all of the MITRE cert stuff. We don't want to add that to the open source work.

Also, remove the commented-out code below.

If you remove those things, I don't think there should be any updates to this file.

@jrobble
Copy link
Member

jrobble commented Jan 8, 2024

Please add the Dockerfile for Transformer Tagging.

…semicolons, updated all upstream tags to be lowercase, and updates to readme"
Copy link
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 12 files at r1, 3 of 4 files at r2, 3 of 6 files at r3, 4 of 4 files at r4, 5 of 10 files at r7, 3 of 3 files at r9, 4 of 4 files at r10, 5 of 5 files at r11, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Chris7C)

@Chris7C Chris7C merged commit 531e8ef into develop Feb 1, 2024
@Chris7C Chris7C deleted the feature/transformer-tagging branch February 1, 2024 21:06
hhuangMITRE pushed a commit that referenced this pull request Feb 27, 2024
* Updated keyword tagging output properties to support tag prefix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants