Add health check to ocv face #347
Conversation
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @brosenberg42)
cpp/OcvFaceDetection/plugin-files/meds_faces_image.png line 0 at r1 (raw file):
Let's add a NOTICE like we have in/test/data/test_imgs/NOTICE.
Also, consider creating a separate dir called /plugin-files/data/health with the image, NOTICE, and .ini file in it.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @brosenberg42)
cpp/OcvFaceDetection/plugin-files/meds_faces_image.png line at r1 (raw file):
Previously, jrobble (Jeff Robble) wrote…
Let's add a
NOTICElike we have in/test/data/test_imgs/NOTICE.Also, consider creating a separate dir called
/plugin-files/data/healthwith the image,NOTICE, and .ini file in it.
I thought about this some more.
Instead of /plugin-files/data/health, maybe we should standardize on /plugin-files/health.
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @brosenberg42 and @jrobble)
cpp/OcvFaceDetection/plugin-files/meds_faces_image.png line at r1 (raw file):
Previously, jrobble (Jeff Robble) wrote…
I thought about this some more.
Instead of
/plugin-files/data/health, maybe we should standardize on/plugin-files/health.
Done.
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @brosenberg42)
2 participants
Issues:
Related PRs:
This change is