Skip to content

Conversation

hhuangMITRE
Copy link
Contributor

@hhuangMITRE hhuangMITRE commented Apr 30, 2024

Copy link
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @brosenberg42 and @hhuangMITRE)


python/AzureTranslation/tests/test_acs_translation.py line 1040 at r1 (raw file):

    def test_guess_split_edge_cases(self):

Where did this test go?

Copy link
Contributor Author

@hhuangMITRE hhuangMITRE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @brosenberg42 and @jrobble)


python/AzureTranslation/tests/test_acs_translation.py line 1040 at r1 (raw file):

Previously, jrobble (Jeff Robble) wrote…

Where did this test go?

Ah, that got left out (in addition to the wtp-advanced/basic test), I've done another check and transferred this test into detection/nlp_text_splitter/tests/test_text_splitter.py. Thanks for spotting that.

Copy link
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @brosenberg42)

@hhuangMITRE hhuangMITRE merged commit c023745 into develop May 7, 2024
@hhuangMITRE hhuangMITRE deleted the feat/text-split-pkg branch May 7, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants