Skip to content

Conversation

clnowacki
Copy link
Member

@clnowacki clnowacki commented Apr 9, 2024

Copy link
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @clnowacki)

a discussion (no related file):
Update this file: https://github.com/openmpf/openmpf-cpp-component-sdk/blob/develop/detection/examples/AudioOnlyComponent/README.md

It mentions OpenCV 4.5.0.

Also, check the READMEs for the other example components in that dir.


Copy link
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @clnowacki)

Copy link
Member Author

@clnowacki clnowacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @clnowacki)

a discussion (no related file):

Previously, jrobble (Jeff Robble) wrote…

Update this file: https://github.com/openmpf/openmpf-cpp-component-sdk/blob/develop/detection/examples/AudioOnlyComponent/README.md

It mentions OpenCV 4.5.0.

Also, check the READMEs for the other example components in that dir.

done


Copy link
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @clnowacki)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants