Skip to content

Commit d04a75f

Browse files
committed
some fix for flaky e2e test
1 parent dfb4cfb commit d04a75f

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

examples/pages-router/src/middleware.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ export function middleware(request: NextRequest) {
88
return NextResponse.next({
99
headers: {
1010
"x-from-middleware": "true",
11+
// We need to disable caching in cloudfront to ensure we always hit the origin for this test
12+
"cache-control": "private, no-store",
1113
},
1214
});
1315
}

packages/tests-e2e/tests/pagesRouter/data.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,11 @@ test("fix _next/data", async ({ page }) => {
44
await page.goto("/");
55

66
const isrJson = page.waitForResponse("/_next/data/*/en/isr.json");
7-
await page.locator('[href="/isr/"]').click();
87
const response = await isrJson;
98
expect(response.ok()).toBe(true);
109
expect(response.request().url()).toMatch(/\/_next\/data\/.*\/en\/isr\.json$/);
10+
11+
await page.locator('[href="/isr/"]').click();
1112
await page.waitForURL("/isr/");
1213

1314
const homeJson = page.waitForResponse("/_next/data/*/en.json");

0 commit comments

Comments
 (0)