Skip to content

fix: return error if all the dashboard data could not be loaded #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2025
Merged

fix: return error if all the dashboard data could not be loaded #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,21 @@ pub async fn generate_report(
log::error!(
"[REPORT] error finding the span element for dashboard {dashboard_id}: {e}"
);
log::info!("[REPORT] proceeding with whatever data is loaded until now");
let page_url = page.url().await;
take_screenshot(&page, org_id, dashboard_id, true).await?;
// Take a screenshot before killing the browser to help debug login issues
log::info!("killing browser");
browser.close().await?;
browser.wait().await?;
handle.await?;
browser.kill().await;
if let Err(e) = user_tmp_dir.close() {
log::error!("Error closing temporary directory for dashboard {dashboard_id}: {e}");
}
return Err(anyhow::anyhow!(
"[REPORT] error finding the span element for dashboard {dashboard_id}: {e}: current url: {:#?}. Some panels could not be loaded within the timeout.",
page_url
));
}
Ok(dur) => {
log::info!(
Expand Down