Skip to content

Conversation

@DriesSchaumont
Copy link
Member

Changelog

Add scope to configs

Issue ticket number and link

Closes #xxxx (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

@DriesSchaumont DriesSchaumont marked this pull request as ready for review May 2, 2025 09:36
@DriesSchaumont DriesSchaumont requested a review from rcannood May 5, 2025 11:13
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Could you add an entry to the changelog?
  • I'm inclined to make more of these components private. I have an idea of how we might be able to decide public / private / test -- would you like me to give it a shot?

rcannood

This comment was marked as outdated.

Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if a changelog entry is added

@DriesSchaumont DriesSchaumont requested a review from rcannood May 19, 2025 12:39
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rcannood rcannood merged commit 99e268e into main May 19, 2025
117 checks passed
@rcannood rcannood deleted the add_scope branch May 19, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants