Skip to content

Put output_compression argument in base #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 6, 2025
Merged

Put output_compression argument in base #1017

merged 8 commits into from
May 6, 2025

Conversation

@DriesSchaumont
Copy link
Member

@DriesSchaumont DriesSchaumont commented May 2, 2025 •
edited
Loading

Changelog

... Describe your changes ...

Issue ticket number and link

Closes #xxxx (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

@DriesSchaumont DriesSchaumont mentioned this pull request May 2, 2025
Merged
10 tasks
rcannood
rcannood previously approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • For reference, __merge__: [., /src/base/h5_compression_argument.yaml] is a bit redundant -- you might as well just use __merge__: "/src/base/h5_compression_argument.yaml" ^^
  • There is one suggestion
  • Can you add something to the changelog?

@DriesSchaumont DriesSchaumont marked this pull request as ready for review May 6, 2025 13:59
@DriesSchaumont DriesSchaumont requested a review from rcannood May 6, 2025 13:59
rcannood
rcannood approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DriesSchaumont DriesSchaumont merged commit 257ced6 into main May 6, 2025
69 checks passed
@DriesSchaumont DriesSchaumont deleted the put_compression_argument_in_base branch May 6, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rcannood rcannood rcannood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DriesSchaumont @rcannood