Skip to content

Conversation

@dorien-er
Copy link
Contributor

@dorien-er dorien-er commented Jul 7, 2025

Changelog

  • new from_h5ad_or_h5mu_to_seurat component to convert an h5ad file or a single modality from an h5mu file to Seurat
  • deprication of from_h5mu_to_seurat

Issue ticket number and link

Closes #xxxx (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

@dorien-er dorien-er marked this pull request as draft July 7, 2025 14:54
@dorien-er dorien-er requested a review from DriesSchaumont July 8, 2025 11:58
@dorien-er dorien-er marked this pull request as ready for review July 8, 2025 11:58
Copy link
Member

@DriesSchaumont DriesSchaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍 LGTM!

@dorien-er
Copy link
Contributor Author

Great 👍 LGTM!

thx for the reticulate refactoring! 🙏

@DriesSchaumont DriesSchaumont merged commit 8a4576a into main Jul 9, 2025
6 checks passed
@DriesSchaumont DriesSchaumont deleted the h5mu-to-seurat branch July 9, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants