Skip to content

Conversation

@DriesSchaumont
Copy link
Member

Changelog

Provide clean error message when running scrublet on an empty array

Issue ticket number and link

Closes #xxxx (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

@DriesSchaumont DriesSchaumont marked this pull request as ready for review December 10, 2024 17:34
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question -- otherwise LGTM!

Comment on lines 49 to 50
f"Modality {mod} of input Mudata " f"{par['input']} appears to be empty."
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include the shape of the input mudata in this message?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done!

@DriesSchaumont DriesSchaumont merged commit 49066af into main Dec 11, 2024
4 checks passed
@DriesSchaumont DriesSchaumont deleted the filter_with_scrublet_empty_mudata branch December 11, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants