Skip to content

Conversation

ebariaux
Copy link

JDK used is still 11, see openremote/openremote#2136

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project to use more recent versions of Gradle and removes deprecated API calls. The changes modernize the build system by upgrading from Gradle 7.4.2 to 8.14.3 and updating the plugin name to reflect the new namespace.

  • Updates Gradle wrapper from version 7.4.2 to 8.14.3
  • Removes deprecated forUseAtConfigurationTime() calls from provider configurations
  • Updates plugin name from com.cherryperry.gradle-file-encrypt to io.openremote.com.cherryperry.gradle-file-encrypt

Reviewed Changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
gradle/wrapper/gradle-wrapper.properties Updates Gradle distribution to 8.14.3 and adds network timeout
gradle.properties Removes deprecated MaxPermSize JVM argument
src/main/kotlin/com/cherryperry/gfe/providers/ Removes deprecated forUseAtConfigurationTime() calls
src/main/kotlin/com/cherryperry/gfe/Utils.kt Updates plugin name constant
src/test/kotlin/com/cherryperry/gfe/FileEncryptPluginFunctionalTest.kt Updates test plugin name and adds Gradle version test cases
gradlew, gradlew.bat Updates wrapper scripts with improvements
detekt.yml Updates detekt configuration with rule changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@richturner richturner requested review from richturner and removed request for a team September 18, 2025 07:09
@ebariaux
Copy link
Author

FYI, verified locally that new plugin version properly decrypts encrypted file we have in the openremote repository.

@ebariaux ebariaux merged commit 0d15b52 into master Sep 18, 2025
4 checks passed
@ebariaux ebariaux deleted the enhancement/up-to-date branch September 18, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants