Clarify ngx.timer.every callback argument conventions #1409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
requested changes
Nov 2, 2018
| 1. timer will be created every `delay` seconds until the current Nginx worker process starts exiting. | ||
|
|
||
| Like [ngx.timer.at](#ngxtimerat), the `callback` argument will be called | ||
| automatically with the arguments `premature`, `user_arg1`, `user_arg2`, etc. |
Member
There was a problem hiding this comment.
Please do not edit this file directly. Instead, make your edits to the HttpLuaModule.wiki file, and generate the README file with the wiki2markdown.pl utility.
doujiang24
pushed a commit
that referenced
this pull request
Mar 30, 2020
Member
|
@chriskuehl I have synced your changes to the HttpLuaModule.wiki file and already merged it, thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby grant the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.
We recently implemented a new
ngx.timer.everytimer in our codebase and didn't realize that the calling conventions ofngx.timer.every's callback also include theprematureargument. When we were implementing the feature, we actually interpreted the docs such that we thoughtprematurewas only used forattimers.Here's a quick clarification to those docs to make clear that the way the
callbackis called is the same as forngx.timer.at.