Add ParseExceptionResult marker in DefaultVisit()

[knutwannheden]

By adding this marker we can use the FindParseFailures recipe to produce reports, where we get a corresponding entry for each J.Unknown with that marker, including relevant details.

[knutwannheden]

Oops, this slipped in by accident. Let me know if I should revert.

[macsux]

Doesn't matter, it's not correct anyways

[knutwannheden]

I saw you had changed it to something else in the mean time. That definitely didn't work for me. With this change I could at least get tests like this (which I believe you reported somewhere) working:

void Test()
{
    ""blah"".Skip()
        .ToList();
}

But if you say it isn't correct, I believe you. I will let you take over.

[macsux]

No if you had a fix please revert as I was still wrapping my head around the issue.

…

On Tue, Oct 1, 2024, 4:09 p.m. Knut Wannheden ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Rewrite/src/Rewrite.CSharp/Parser/CSharpParserVisitor.cs <#14 (comment)> : > @@ -397,7 +403,7 @@ public override J VisitIdentifierName(IdentifierNameSyntax node) Core.Tree.RandomId(), prefix, Markers.EMPTY, - new JRightPadded<Expression>(fa.Target, Format(Leading(node.ArgumentList)), Markers.EMPTY), + new JRightPadded<Expression>(fa.Target, fa.Padding.Name.Before, Markers.EMPTY), I saw you had changed it to something else in the mean time. That definitely didn't work for me. With this change I could at least get tests like this (which I believe you reported somewhere) working: void Test(){ ""blah"".Skip() .ToList();} But if you say it isn't correct, I believe you. I will let you take over. — Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAINFWEWTONIOMTEIUHMSATZZL6N7AVCNFSM6AAAAABPB4XRFGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNBRGM2TQMZYHA> . You are receiving this because your review was requested.Message ID: ***@***.***>

[knutwannheden]

I am sorry I am a bit lost between your comment:

Doesn't matter, it's not correct anyways

and now:

No if you had a fix please revert as I was still wrapping my head around the issue.

I think it is just easiest if you update / revert it to what is best for you.