This repository was archived by the owner on May 12, 2025. It is now read-only.
Implemented support for FunctionExpression #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created new JS.FunctionDeclaration to represent ts.FunctionExpression and ts.FunctionDeclaration. Refactored visitFunctionDeclaration from J.MethodDeclaration to JS.FunctionDeclaration
arodionov
requested review from
OlegDokuka and
knutwannheden
and removed request for
knutwannheden
arodionov
commented
Nov 13, 2024
| describe('function decorator mapping', () => { | ||
| // according to TypeScript documentation decorators are not allowed with | ||
| // standalone functions https://www.typescriptlang.org/docs/handbook/decorators.html | ||
| describe.skip('function decorator mapping', () => { |
There was a problem hiding this comment.
Skipped decorators' tests can be removed.
According to TypeScript documentation, decorators are not allowed with standalone functions https://www.typescriptlang.org/docs/handbook/decorators.html
OlegDokuka
approved these changes
Nov 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new
JS.FunctionDeclarationto representts.FunctionExpressionandts.FunctionDeclaration.Refactored
visitFunctionDeclarationfromJ.MethodDeclarationtoJS.FunctionDeclarationThe reason to implement a new custom type (and don't use
J.MethodDeclarationorJS.ArrowFunctioninstead):ts.FunctionExpressionis an expression, butJ.MethodDeclarationis a statementts.FunctionDeclarationcan have generics, butJS.ArrowFunctiondoesn't support them