This repository was archived by the owner on May 12, 2025. It is now read-only.
Prevent potential Java 21 issue #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vailable on classpath
timtebeek
reviewed
Feb 17, 2025
|
|
||
| s = s.withCases(s.getCases().withStatements(ListUtils.flatMap(s.getCases().getStatements(), it -> { | ||
| if (it instanceof J.Case && changeCondition(((J.Case) it).getExpressions())) { | ||
| if (it instanceof J.Case && changeCondition(((J.Case) it).getCaseLabels())) { |
There was a problem hiding this comment.
Same concern as on the Python counter part: I'm not sure these replacement fields are populated here already.
There was a problem hiding this comment.
Oleg changed the javascript remoting parser to use the CaseLabels back when it was introduced
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Apply newest
getCaseLabelinstead ofgetExpressionAnyone you would like to review specifically?
@timtebeek
Have you considered any alternatives or workarounds?
Any additional context
Checklist