Skip to content

Conversation

@ranuradh
Copy link
Contributor

@ranuradh ranuradh commented Jun 17, 2024

What's changed?

This PR contains 2 recipes.
org.openrewrite.java.migrate.RemovedJavaXMLWSModuleProvided
image

org.openrewrite.java.migrate.RemovedJaxBModuleProvided
image

What's your motivation?

The recipe updates the application by removing the modules that are now excluded from JDK11 from the Gradle and Maven build files.

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

@cjobinabo

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@ranuradh ranuradh requested a review from cjobinabo June 17, 2024 17:26
@ranuradh ranuradh added the recipe Recipe requested label Jun 17, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/java/migrate/IBMSemeruTest.java
    • lines 22-21
    • lines 30-30

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/java/migrate/IBMSemeruTest.java
    • lines 22-21
    • lines 30-30

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/java/migrate/IBMSemeruTest.java
    • lines 22-21
    • lines 30-30

Copy link
Contributor

@cjobinabo cjobinabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the updates Anu.

@ranuradh ranuradh requested a review from timtebeek June 20, 2024 10:40
@ranuradh
Copy link
Contributor Author

@timtebeek if you can review and approve the PR we can then merge it.Thanks!

Copy link
Member

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat addition! I like how you document what the recipes do even if their implementation only delegates to RemoveDependency.

@timtebeek timtebeek changed the title Two Java11 recipes - RemovedJavaXMLWSModuleProvided & RemovedJaxBModuleProvided RemovedJavaXMLWSModuleProvided & RemovedJaxBModuleProvided Jun 20, 2024
@timtebeek timtebeek merged commit 724a244 into openrewrite:main Jun 20, 2024
@ranuradh ranuradh deleted the recipe_RemovedJavaXMLWSModuleProvided branch June 20, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

recipe Recipe requested

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants