-
Notifications
You must be signed in to change notification settings - Fork 107
RemovedJavaXMLWSModuleProvided & RemovedJaxBModuleProvided
#497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RemovedJavaXMLWSModuleProvided & RemovedJaxBModuleProvided
#497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/test/java/org/openrewrite/java/migrate/IBMSemeruTest.java
- lines 22-21
- lines 30-30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/test/java/org/openrewrite/java/migrate/IBMSemeruTest.java
- lines 22-21
- lines 30-30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/test/java/org/openrewrite/java/migrate/IBMSemeruTest.java
- lines 22-21
- lines 30-30
cjobinabo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the updates Anu.
|
@timtebeek if you can review and approve the PR we can then merge it.Thanks! |
timtebeek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat addition! I like how you document what the recipes do even if their implementation only delegates to RemoveDependency.
RemovedJavaXMLWSModuleProvided & RemovedJaxBModuleProvided
What's changed?
This PR contains 2 recipes.

org.openrewrite.java.migrate.RemovedJavaXMLWSModuleProvided
org.openrewrite.java.migrate.RemovedJaxBModuleProvided

What's your motivation?
The recipe updates the application by removing the modules that are now excluded from JDK11 from the Gradle and Maven build files.
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
@cjobinabo
Checklist