fix: Handle ImmutableOf as Select on MethodInvocation

[amishra-u]

What's changed?

Fix the bug in the ImmutableOf recipe. The current implementation does not account for the scenario where ImmutableOf is the 'select' property of a MethodInvocation.

Stack trace

"java.lang.IndexOutOfBoundsException: Index: 1
  java.base/java.util.Collections$EmptyList.get(Collections.java:4807)
  org.openrewrite.java.migrate.guava.AbstractNoGuavaImmutableOf$1.isParentTypeDownCast(AbstractNoGuavaImmutableOf.java:149)
  org.openrewrite.java.migrate.guava.AbstractNoGuavaImmutableOf$1.visitMethodInvocation(AbstractNoGuavaImmutableOf.java:71)
  org.openrewrite.java.migrate.guava.AbstractNoGuavaImmutableOf$1.visitMethodInvocation(AbstractNoGuavaImmutableOf.java:68)
  org.openrewrite.java.tree.J$MethodInvocation.acceptJava(J.java:3905)
  org.openrewrite.java.tree.J.accept(J.java:59)
  org.openrewrite.TreeVisitor.visit(TreeVisitor.java:245)
  org.openrewrite.TreeVisitor.visitAndCast(TreeVisitor.java:317)
  org.openrewrite.java.JavaVisitor.visitRightPadded(JavaVisitor.java:1365)
  org.openrewrite.java.JavaVisitor.visitMethodInvocation(JavaVisitor.java:911)
  org.openrewrite.java.migrate.guava.AbstractNoGuavaImmutableOf$1.visitMethodInvocation(AbstractNoGuavaImmutableOf.java:115)
  org.openrewrite.java.migrate.guava.AbstractNoGuavaImmutableOf$1.visitMethodInvocation(AbstractNoGuavaImmutableOf.java:68)
  org.openrewrite.java.tree.J$MethodInvocation.acceptJava(J.java:3905)
  org.openrewrite.java.tree.J.accept(J.java:59)
  org.openrewrite.TreeVisitor.visit(TreeVisitor.java:245)
  org.openrewrite.TreeVisitor.visitAndCast(TreeVisitor.java:317)
  ..."

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

Future Work

Ideally I would like to recipe handle the above case also. Will create another PR to handle such scenario.

[timtebeek]

Thanks for the fix here! I like how the solution is clearer as well;

To handle this case separately you might want to look at cases where the parent method invocation .select matches the immutable method we're after, and work from there.