Skip to content

Adds Java version 17 in Github CI build #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2022
Merged

Adds Java version 17 in Github CI build #1609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
547e79d
Adds Java version 17 in Github CI build
DarshitChanpura Feb 11, 2022
d202106
Disables HTTPJwtAuthenticatorTest for Java 17 build due to a known bug
DarshitChanpura Feb 16, 2022
645be1c
Disables HTTPJwtAuthenticatorTest for Java 17 build using junit 4 and…
DarshitChanpura Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
fail-fast: true
matrix:
jdk: [8, 11, 14]
jdk: [8, 11, 14, 17]

steps:

Expand Down
12 changes: 12 additions & 0 deletions src/test/java/com/amazon/dlic/auth/http/jwt/HTTPJwtAuthenticatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import java.util.HashMap;
import java.util.Map;

import org.junit.Before;
import org.opensearch.common.settings.Settings;

import org.apache.http.HttpHeaders;
Expand All @@ -42,6 +43,8 @@
import org.opensearch.security.util.FakeRestRequest;
import com.google.common.io.BaseEncoding;

import static org.junit.Assume.assumeFalse;

public class HTTPJwtAuthenticatorTest {

final static byte[] secretKey = new byte[1024];
Expand All @@ -50,6 +53,15 @@ public class HTTPJwtAuthenticatorTest {
new SecureRandom().nextBytes(secretKey);
}

/*
This test fails during Java 17 build due to a known bug: https://bugs.openjdk.java.net/browse/JDK-8251547
TODO: This method should be removed once a fix is implemented
Copy link
Member

@peternied peternied Feb 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than create a TODO can you create an issue that captures what is wrong and what should be done (If you know)?

Copy link
Member Author

@DarshitChanpura DarshitChanpura Feb 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already created an issue and connected it to this PR as well

#1620

*/
@Before
public void isJavaVersionBelow17(){
assumeFalse(System.getProperty("java.version").startsWith("17"));
}

@Test
public void testNoKey() throws Exception {

Expand Down