Fix the bug that no error occurred when client is unavailable #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add default deadline (timeout) Signed-off-by: Eric Zhao <sczyh16@gmail.com>
sczyh30
added
kind/bug
jnan806
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Zhao sczyh16@gmail.com
Describe what this PR does / why we need it
Fix the bug that no error occurred when gRPC connection is unavailable.
Does this pull request fix one issue?
Fixes #20
Describe how you did it
Add a default deadline (timeout) for the gRPC stub. Then error will occur when the deadline exceeds.
Describe how to verify it
Run the demo with a bad remote endpoint.
Special notes for reviews
We may need to make the timeout configurable later.