-
Notifications
You must be signed in to change notification settings - Fork 28
SRVLOGIC-261: Update Serverless Logic docs to latest #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRVLOGIC-261: Update Serverless Logic docs to latest #113
Conversation
@domhanak: This pull request references SRVLOGIC-261 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
✅ Deploy Preview for jazzy-shortbread-5f62b7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
modules/serverless-logic/pages/cloud/operator/install-serverless-operator.adoc
Outdated
Show resolved
Hide resolved
Finish the review. The rest of the docs LGTM |
Co-authored-by: Jakub Schwan <jschwan@redhat.com>
Co-authored-by: Jakub Schwan <jschwan@redhat.com>
@wmedvede @jakubschwan gentle reminder to approove if all good |
modules/serverless-logic/pages/cloud/operator/install-serverless-operator.adoc
Outdated
Show resolved
Hide resolved
…est` in the midstream docs
@wmedvede @jakubschwan I added the missing Please check - https://issues.redhat.com/browse/SRVLOGIC-308 |
FYI @ricardozanini @krisv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: domhanak, jakubschwan, ReToCode, wmedvede The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
This is good to go if any1 can merge please |
Do not merge yet please, looking if it is all good.
Ticket: https://issues.redhat.com/browse/SRVLOGIC-261