Skip to content

Conversation

domhanak
Copy link
Contributor

Do not merge yet please, looking if it is all good.

Ticket: https://issues.redhat.com/browse/SRVLOGIC-261

@openshift-ci-robot
Copy link

@domhanak: This pull request references SRVLOGIC-261 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.17.0" version, but no target version was set.

In response to this:

Do not merge yet please, looking if it is all good.

Ticket: https://issues.redhat.com/browse/SRVLOGIC-261

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for jazzy-shortbread-5f62b7 ready!

Name Link
🔨 Latest commit 6d582e9
🔍 Latest deploy log https://app.netlify.com/sites/jazzy-shortbread-5f62b7/deploys/669f52c8c07f2c0008ee18bf
😎 Deploy Preview https://deploy-preview-113--jazzy-shortbread-5f62b7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wmedvede
Copy link
Contributor

Geneal comment icons not shown here
image

@wmedvede
Copy link
Contributor

Jobs service bits are missing

image

@jakubschwan
Copy link
Contributor

Sharing some review notes. I'm probably in half of the review right now.

Finish the review. The rest of the docs LGTM

@domhanak
Copy link
Contributor Author

@wmedvede @jakubschwan gentle reminder to approove if all good

@domhanak
Copy link
Contributor Author

@domhanak domhanak requested a review from gmunozfe July 23, 2024 08:24
@domhanak
Copy link
Contributor Author

FYI @ricardozanini @krisv

Copy link
Contributor

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold

Copy link

openshift-ci bot commented Jul 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: domhanak, jakubschwan, ReToCode, wmedvede

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ReToCode
Copy link
Contributor

/unhold

@domhanak
Copy link
Contributor Author

domhanak commented Jul 31, 2024

This is good to go if any1 can merge please

@ricardozanini ricardozanini merged commit 87a954d into openshift-knative:master Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants