SRVLOGIC-138: [Docs] Update OpenShift Serverless Logic for DP6 release #94

VaniHaripriya · 2023-05-24T22:16:59Z

Following changes have been added:

[KOGITO-8676] OnOverflow management (#315)
[KOGITO-8409]Added info about CloudEvents to Knative functions (#312)
[KOGITO-8908] Documenting sysout arguments and log level (#321)
[KOGITO-8443] Added note about simplified format for Knative service discovery(#326)
Updated with steps to overcome an issue on macOS (#274)
[KOGITO-8818] Rearrange guides to add operator and quarkus cloud (#313)
[KOGITO-8820] Fix references in timeout guide and create a new section for job service(#320)
Updated versions in antora.yml file
Updated Release notes

openshift-ci-robot · 2023-05-24T22:17:02Z

@VaniHaripriya: This pull request references SRVLOGIC-138 which is a valid jira issue.

In response to this:

Jira : SRVLOGIC-138

Following changes have been added:

[KOGITO-8676] OnOverflow management (#315)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

netlify · 2023-05-24T22:17:05Z

✅ Deploy Preview for jazzy-shortbread-5f62b7 ready!

Name	Link
🔨 Latest commit	`b62e60c`
🔍 Latest deploy log	https://app.netlify.com/sites/jazzy-shortbread-5f62b7/deploys/648c8bb4481b090008f69d5b
😎 Deploy Preview	https://deploy-preview-94--jazzy-shortbread-5f62b7.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

openshift-ci-robot · 2023-05-24T23:37:34Z

@VaniHaripriya: This pull request references SRVLOGIC-138 which is a valid jira issue.

In response to this:

Jira : SRVLOGIC-138

Following changes have been added:

[KOGITO-8676] OnOverflow management (#315)

[KOGITO-8409]Added info about CloudEvents to Knative functions (#312)

[KOGITO-8908] Documenting sysout arguments and log level (#321)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…discovery(#326)

openshift-ci-robot · 2023-05-25T15:14:39Z

@VaniHaripriya: This pull request references SRVLOGIC-138 which is a valid jira issue.

In response to this:

Jira : SRVLOGIC-138

Following changes have been added:

[KOGITO-8676] OnOverflow management (#315)

[KOGITO-8409]Added info about CloudEvents to Knative functions (#312)

[KOGITO-8908] Documenting sysout arguments and log level (#321)

[KOGITO-8443] Added note about simplified format for Knative service discovery(#326)

Updated with steps to overcome an issue on macOS (#274)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-05-26T22:29:55Z

@VaniHaripriya: This pull request references SRVLOGIC-138 which is a valid jira issue.

In response to this:

Jira : SRVLOGIC-138

Following changes have been added:

[KOGITO-8676] OnOverflow management (#315)

[KOGITO-8409]Added info about CloudEvents to Knative functions (#312)

[KOGITO-8908] Documenting sysout arguments and log level (#321)

[KOGITO-8443] Added note about simplified format for Knative service discovery(#326)

Updated with steps to overcome an issue on macOS (#274)

[KOGITO-8818] Rearrange guides to add operator and quarkus cloud (#313)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…n for job service(#320)

openshift-ci-robot · 2023-05-26T23:03:02Z

@VaniHaripriya: This pull request references SRVLOGIC-138 which is a valid jira issue.

In response to this:

Jira : SRVLOGIC-138

Following changes have been added:

[KOGITO-8676] OnOverflow management (#315)

[KOGITO-8409]Added info about CloudEvents to Knative functions (#312)

[KOGITO-8908] Documenting sysout arguments and log level (#321)

[KOGITO-8443] Added note about simplified format for Knative service discovery(#326)

Updated with steps to overcome an issue on macOS (#274)

[KOGITO-8818] Rearrange guides to add operator and quarkus cloud (#313)

[KOGITO-8820] Fix references in timeout guide and create a new section for job service(#320)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-05-30T16:58:04Z

@VaniHaripriya: This pull request references SRVLOGIC-138 which is a valid jira issue.

In response to this:

Jira : SRVLOGIC-138

Following changes have been added:

[KOGITO-8676] OnOverflow management (#315)

[KOGITO-8409]Added info about CloudEvents to Knative functions (#312)

[KOGITO-8908] Documenting sysout arguments and log level (#321)

[KOGITO-8443] Added note about simplified format for Knative service discovery(#326)

Updated with steps to overcome an issue on macOS (#274)

[KOGITO-8818] Rearrange guides to add operator and quarkus cloud (#313)

[KOGITO-8820] Fix references in timeout guide and create a new section for job service(#320)

Updated versions in antora.yml file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-05-31T20:56:08Z

@VaniHaripriya: This pull request references SRVLOGIC-138 which is a valid jira issue.

In response to this:

Jira : SRVLOGIC-138

Following changes have been added:

[KOGITO-8676] OnOverflow management (#315)

[KOGITO-8409]Added info about CloudEvents to Knative functions (#312)

[KOGITO-8908] Documenting sysout arguments and log level (#321)

[KOGITO-8443] Added note about simplified format for Knative service discovery(#326)

Updated with steps to overcome an issue on macOS (#274)

[KOGITO-8818] Rearrange guides to add operator and quarkus cloud (#313)

[KOGITO-8820] Fix references in timeout guide and create a new section for job service(#320)

Updated versions in antora.yml file

Updated Release notes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

radtriste

Also serverless-logic-web-tools-enable-kogito-swf-visualization.adoc still contain some {context} strings

radtriste · 2023-06-02T13:56:49Z

modules/serverless-logic/pages/cloud/quarkus/deploying-on-kubernetes.adoc

Check the title and the {context} string which does not exist:
https://deploy-preview-94--jazzy-shortbread-5f62b7.netlify.app/docs/latest/serverless-logic/cloud/quarkus/deploying-on-kubernetes.html

radtriste · 2023-06-02T13:58:26Z

modules/serverless-logic/pages/integrations/custom-functions-knative.adoc


+== Sending as CloudEvent
+
+Knative functions support https://github.com/knative/func/blob/main/docs/function-templates/quarkus.md#invocation-parameters[CloudEvent as the message protocol]. {context} can create and post CloudEvent messages in `functionRef`. For more information see xref:core/custom-functions-support.adoc#sending-cloudevents[]


Suggested change

Knative functions support https://github.com/knative/func/blob/main/docs/function-templates/quarkus.md#invocation-parameters[CloudEvent as the message protocol]. {context} can create and post CloudEvent messages in `functionRef`. For more information see xref:core/custom-functions-support.adoc#sending-cloudevents[]

Knative functions support https://github.com/knative/func/blob/main/docs/function-templates/quarkus.md#invocation-parameters[CloudEvent as the message protocol]. {product_name} can create and post CloudEvent messages in `functionRef`. For more information see xref:core/custom-functions-support.adoc#sending-cloudevents[]

radtriste · 2023-06-02T13:59:05Z

modules/serverless-logic/pages/persistence/postgresql-flyway-migration.adoc

Check for {context} in that file ;)

Thank you Tristan, replaced all the {context} to {product_name}.

antora.yml

modules/serverless-logic/pages/release-notes.adoc

Co-authored-by: Marián Macik <macik.marian@gmail.com>

krisv · 2023-06-06T12:37:46Z

antora.yml

+    operator_version: v1.38.0
    kogito_devservices_imagename: registry.redhat.io/openshift-serverless-1-tech-preview/logic-data-index-ephemeral-rhel8:1.24.0-11
    kogito_examples_repository_url: 'https://github.com/kiegroup/kogito-examples'
    kogito_sw_examples_url: https://github.com/kiegroup/kogito-examples/tree/1.32.x/serverless-workflow-examples


This probably needs updating to 1.38 as well @VaniHaripriya ?

krisv · 2023-06-06T12:38:35Z

antora.yml

    docker_compose_min_version: 1.27.2
-    operator_version: v1.35.0
+    operator_version: v1.38.0
    kogito_devservices_imagename: registry.redhat.io/openshift-serverless-1-tech-preview/logic-data-index-ephemeral-rhel8:1.24.0-11


This looks outdated, but I don't think it's used anymore (as this should be set by default), so maybe best to remove?

@krisv Thank you Kris, I will remove them.

…docs into migrate-to-1.38.x

radtriste · 2023-06-13T14:46:29Z

Is that on purpose that the Cloud part is not included into the Serverless Logic but rather a totally different menu on the left panel ?

modules/ROOT/nav.adoc

Co-authored-by: Marián Macik <macik.marian@gmail.com>

VaniHaripriya · 2023-06-13T17:31:05Z

Is that on purpose that the Cloud part is not included into the Serverless Logic but rather a totally different menu on the left panel ?

Thank you Tristan. Updating the nav doc with correct fromat.

radtriste

one minor comment

modules/serverless-logic/pages/cloud/index.adoc

ricardozanini · 2023-06-19T18:45:53Z

@krisv wanna take a final look?

openshift-ci · 2023-06-23T07:20:19Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: krisv, MarianMacik, radtriste, ricardozanini, VaniHaripriya

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[KOGITO-8676] OnOverflow management

4b4cf09

openshift-ci-robot added the jira/valid-reference label May 24, 2023

VaniHaripriya added 2 commits May 24, 2023 18:30

[KOGITO-8409]Added info about CloudEvents to Knative functions (#312)

f0a783f

[KOGITO-8908] Documenting sysout arguments and log level (#321)

cd1e942

VaniHaripriya added 2 commits May 25, 2023 09:36

[KOGITO-8443] Added note about simplified format for Knative service …

e6d1c75

…discovery(#326)

Updated with steps to overcome an issue on macOS (#274)

e05ca35

[KOGITO-8818] Rearrange guides to add operator and quarkus cloud (#313)

84a22b6

[KOGITO-8820] Fix references in timeout guide and create a new sectio…

a9de82c

…n for job service(#320)

VaniHaripriya added 2 commits May 26, 2023 18:20

[KOGITO-8818] Updated navigation page with correct paths

eed5bb5

[SRVLOGIC-138] Updated versions in antora.yml file

30630cd

ricardozanini requested review from MarianMacik, radtriste and ricardozanini May 31, 2023 20:02

[SRVLOGIC-138]- Updated Release notes

2c7f9e7

radtriste requested changes Jun 2, 2023

View reviewed changes

[SRVLOGIC-138] Replaced context to product_name in all the docs

a3c91b0

VaniHaripriya requested a review from radtriste June 2, 2023 15:35

MarianMacik reviewed Jun 5, 2023

View reviewed changes

Apply suggestions from code review

a334e2f

Co-authored-by: Marián Macik <macik.marian@gmail.com>

krisv suggested changes Jun 6, 2023

View reviewed changes

VaniHaripriya added 2 commits June 6, 2023 17:26

[SRVLOGIC-138] Updated antora file as per comments

498148a

Merge branch 'migrate-to-1.38.x' of https://github.com/VaniHaripriya/…

322a657

…docs into migrate-to-1.38.x

[SRVLOGIC-138] Updated release notes as per comments

c9d7b2a

VaniHaripriya requested a review from MarianMacik June 9, 2023 14:31

[SRVLOGIC-138] Update Release notes

197bd21

MarianMacik reviewed Jun 13, 2023

View reviewed changes

modules/ROOT/nav.adoc Outdated Show resolved Hide resolved

Update modules/ROOT/nav.adoc

97e1710

Co-authored-by: Marián Macik <macik.marian@gmail.com>

[SRVLOGIC-138] - Updated nav doc

75fb7b4

radtriste approved these changes Jun 15, 2023

View reviewed changes

modules/serverless-logic/pages/cloud/index.adoc Show resolved Hide resolved

[SRVLOGIC-138] - Updated nav doc

b62e60c

ricardozanini approved these changes Jun 19, 2023

View reviewed changes

krisv approved these changes Jun 22, 2023

View reviewed changes

radtriste requested a review from MarianMacik June 23, 2023 06:46

MarianMacik approved these changes Jun 23, 2023

View reviewed changes

radtriste merged commit 83de874 into openshift-knative:master Jun 23, 2023


		== Sending as CloudEvent

		Knative functions support https://github.com/knative/func/blob/main/docs/function-templates/quarkus.md#invocation-parameters[CloudEvent as the message protocol]. {context} can create and post CloudEvent messages in `functionRef`. For more information see xref:core/custom-functions-support.adoc#sending-cloudevents[]

SRVLOGIC-138: [Docs] Update OpenShift Serverless Logic for DP6 release #94

SRVLOGIC-138: [Docs] Update OpenShift Serverless Logic for DP6 release #94

Uh oh!

Conversation

VaniHaripriya commented May 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented May 24, 2023

Uh oh!

netlify bot commented May 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for jazzy-shortbread-5f62b7 ready!

Uh oh!

openshift-ci-robot commented May 24, 2023

Uh oh!

openshift-ci-robot commented May 25, 2023

Uh oh!

openshift-ci-robot commented May 26, 2023

Uh oh!

openshift-ci-robot commented May 26, 2023

Uh oh!

openshift-ci-robot commented May 30, 2023

Uh oh!

openshift-ci-robot commented May 31, 2023

Uh oh!

radtriste left a comment

Choose a reason for hiding this comment

Uh oh!

radtriste Jun 2, 2023

Choose a reason for hiding this comment

Uh oh!

radtriste Jun 2, 2023

Choose a reason for hiding this comment

Uh oh!

radtriste Jun 2, 2023

Choose a reason for hiding this comment

Uh oh!

VaniHaripriya Jun 2, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

krisv Jun 6, 2023

Choose a reason for hiding this comment

Uh oh!

krisv Jun 6, 2023

Choose a reason for hiding this comment

Uh oh!

VaniHaripriya Jun 6, 2023

Choose a reason for hiding this comment

Uh oh!

radtriste commented Jun 13, 2023

Uh oh!

Uh oh!

VaniHaripriya commented Jun 13, 2023

Uh oh!

radtriste left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ricardozanini commented Jun 19, 2023

Uh oh!

openshift-ci bot commented Jun 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

VaniHaripriya commented May 24, 2023 •

edited

Loading

netlify bot commented May 24, 2023 •

edited

Loading