Remove CI_TOKEN requirement for OKD deployments

[bshephar]

This change adds the ability to deploy OKD versions without requiring the CI_TOKEN. This improves the ability to automate deployments and makes dev-scripts accessible to a wider range of users from the community.

[openshift-ci]

Hi @bshephar. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bshephar]

Tested this with the following:

[m3@localhost dev-scripts]$ diff config_m3.sh config_example.sh
11,13c11,13
< #set +x
< #export CI_TOKEN=''
< #set -x
---
> set +x
> export CI_TOKEN=''
> set -x
38,41d37
< #export OPENSHIFT_RELEASE_IMAGE=registry.ci.openshift.org/origin/release:4.15.0-0.okd-2023-08-29-101209
< export OPENSHIFT_RELEASE_IMAGE=registry.ci.openshift.org/origin/release:4.13.0-0.okd-2023-08-29-213951
< export PULL_SECRET_FILE=pull_secret.json
< #export OPENSHIFT_RELEASE_IMAGE=https://amd64.origin.releases.ci.openshift.org/releasestream/4.15.0-0.okd/release/4.15.0-0.okd-2023-08-29-101209
48a45,46
> # NOTE: If set to okd, a OPENSHIFT_RELEASE_IMAGE is required. See the below
> # section on OPENSHIFT_RELEASE_IMAGE for an example.
50c48,55
< export OPENSHIFT_RELEASE_TYPE=okd
---
> #export OPENSHIFT_RELEASE_TYPE=nightly
>
> # OPENSHIFT_RELEASE_IMAGE -
> # Define a specific image to deploy the cluster from. If using OKD,
> # this can be set to an image from: https://amd64.origin.releases.ci.openshift.org
> # For example:
> # export OPENSHIFT_RELEASE_IMAGE=registry.ci.openshift.org/origin/release:4.15.0-0.okd-2023-08-29-101209
> # Default: Undefined
211c216
< export IP_STACK=v4
---
> #export IP_STACK=v4

Deploys fine as of OKD 4.13.

[m3@osp-df-3 dev-scripts]$ oc get nodes
NAME       STATUS   ROLES                  AGE    VERSION
master-0   Ready    control-plane,master   107m   v1.26.7+0ef5eae
master-1   Ready    control-plane,master   107m   v1.26.7+0ef5eae
master-2   Ready    control-plane,master   107m   v1.26.7+0ef5eae
worker-0   Ready    worker                 92m    v1.26.7+0ef5eae
worker-1   Ready    worker                 92m    v1.26.7+0ef5eae

Might need to handle cases where the user doesn't provide a pull secret like I did in the config. I believe OKD has some dummy pull-secret, so we can probably re-use that in the write_pull_secret() function in cases where OPENSHIFT_RELEASE_TYPE == "okd"

[derekhiggins]

/ok-to-test

[openshift-ci]

@bshephar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-bm-bond	f926510	link	false	/test e2e-metal-ipi-bm-bond

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dtantsur]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dtantsur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cybertron]

/lgtm

It seems highly unlikely this broke the bond test so I think it's good to go.