Skip to content

Fix issue with OVMF_CODE.fd symlink #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Fix issue with OVMF_CODE.fd symlink #1698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 02_configure_host.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ ansible-playbook \
# NOTE(elfosardo): /usr/share/OVMF/OVMF_CODE.fd does not exist in the ovmf
# package anymore, so we need to create a link to that until metal3-dev-env
# fixes that, probably when switching to UEFI by default
if ! [[ -f /usr/share/OVMF/OVMF_CODE.fd ]]; then
if ! [[ -f /usr/share/OVMF/OVMF_CODE.fd || -L /usr/share/OVMF/OVMF_CODE.fd ]]; then
Copy link
Member

@mkowalski mkowalski Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://linux.die.net/man/1/test you could do

-e FILE
    FILE exists

instead of both

-f FILE
    FILE exists and is a regular file

and

-L FILE
    FILE exists and is a symbolic link (same as -h)

sudo ln -s /usr/share/edk2/ovmf/OVMF_CODE.fd /usr/share/OVMF/
fi

Expand Down