Pin collections to latest ansible 2.15 compatible versions #1747
Conversation
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @lmiccini. Thanks for your PR. I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
ansible.utils just released a new version that is incompatible with ansible-2.15 (ansible-collections/ansible.utils@7059201) and this results in: ``` TASK [common : Show networks data for debugging (common role)] ***************** task path: /home/dev-scripts/metal3-dev-env/vm-setup/roles/common/tasks/main.yml:42 [WARNING]: Collection ansible.netcommon does not support Ansible version 2.15.12 [WARNING]: Collection ansible.utils does not support Ansible version 2.15.12 redirecting (type: filter) ansible.builtin.nthhost to ansible.netcommon.nthhost redirecting (type: filter) ansible.builtin.nthhost to ansible.netcommon.nthhost ``` this is a proposal to pin these collections until we can upgrade to 2.16. Signed-off-by: Luca Miccini <lmiccini@redhat.com>
|
upstream workaround metal3-io/metal3-dev-env#1517 |
| ansible-galaxy collection install --upgrade ansible.netcommon ansible.posix ansible.utils community.general | ||
| # Let's temporarily pin these collections to the latest compatible with ansible-2.15 | ||
| #ansible-galaxy collection install --upgrade ansible.netcommon ansible.posix ansible.utils community.general | ||
| ansible-galaxy collection install 'ansible.netcommon<=7.2.0' ansible.posix 'ansible.utils<=5.1.2' community.general |
There was a problem hiding this comment.
Did they actually broke the compatibility in 5.1.3? If not, I think we need to allow for patch releases and do <7.3.0 and <5.2.0 instead. WDYT?
There was a problem hiding this comment.
We could do ansible.utils<6.0.0 and ansible.netcommon<8.0.0 as those are the ones bringing the breaking changes. I just went with the latest released (and tested) versions to be on the safe side.
There was a problem hiding this comment.
My worry is about missing future bug fixes. Would you consider a follow-up once we merge this and unblock the CI?
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
openshift-merge-bot
bot
merged commit b261be3
into
openshift-metal3:master
3 participants
ansible.utils just released a new version that is incompatible with ansible-2.15 (ansible-collections/ansible.utils@7059201) and this results in:
this is a proposal to pin these collections until we can upgrade to 2.16.