Skip to content

Conversation

arkadeepsen
Copy link
Member

This PR fixes the Pipfile.lock by making it consistent with the current 4.19 branch. The changes to the Pipfile.lock was backported from the main/release-4.19 branch and in the process some of the changes were missed. This PR fixes the issue.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 27, 2025
@openshift-ci-robot
Copy link

@arkadeepsen: This pull request references Jira Issue OCPBUGS-49361, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-48811 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-48811 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @emmajiafan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR fixes the Pipfile.lock by making it consistent with the current 4.19 branch. The changes to the Pipfile.lock was backported from the main/release-4.19 branch and in the process some of the changes were missed. This PR fixes the issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 27, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2025
Copy link

openshift-ci bot commented Jan 27, 2025

@arkadeepsen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@arkadeepsen
Copy link
Member Author

/cc @chiragkyal

@openshift-ci openshift-ci bot requested a review from chiragkyal January 28, 2025 08:49
@chiragkyal
Copy link
Member

We should add a pre-submit CI job to catch such issues early. openshift/release#60751 should do the work, but it needs some tweaks in the Makefile to have a happy pass.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2025
Copy link

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkadeepsen, chiragkyal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [arkadeepsen,chiragkyal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chiragkyal
Copy link
Member

/retitle [release-4.18] OCPBUGS-49361: UPSTREAM: : Fix Pipefile.lock

@openshift-ci openshift-ci bot changed the title OCPBUGS-49361: UPSTREAM: <carry>: Fix Pipefile.lock [release-4.18] OCPBUGS-49361: UPSTREAM: <carry>: Fix Pipefile.lock Jan 29, 2025
@chiragkyal
Copy link
Member

The changes to the Pipfile.lock was backported from the main/release-4.19 branch and in the process some of the changes were missed.

@arkadeepsen
Copy link
Member Author

/cc @TrilokGeer
for the backport-risk-assessed label

@openshift-ci openshift-ci bot requested a review from TrilokGeer January 29, 2025 08:25
@TrilokGeer
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 29, 2025
@emmajiafan
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 30, 2025
@emmajiafan
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 30, 2025
@openshift-ci-robot
Copy link

@arkadeepsen: This pull request references Jira Issue OCPBUGS-49361, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-48811 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-48811 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @emmajiafan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR fixes the Pipfile.lock by making it consistent with the current 4.19 branch. The changes to the Pipfile.lock was backported from the main/release-4.19 branch and in the process some of the changes were missed. This PR fixes the issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 39ec678 into openshift:release-4.18 Jan 30, 2025
5 checks passed
@openshift-ci-robot
Copy link

@arkadeepsen: Jira Issue OCPBUGS-49361: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-49361 has been moved to the MODIFIED state.

In response to this:

This PR fixes the Pipfile.lock by making it consistent with the current 4.19 branch. The changes to the Pipfile.lock was backported from the main/release-4.19 branch and in the process some of the changes were missed. This PR fixes the issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-ansible-operator
This PR has been included in build openshift-enterprise-ansible-operator-container-v4.18.0-202501300501.p0.g39ec678.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants