-
Notifications
You must be signed in to change notification settings - Fork 580
Bug 2097832: Drop IPv6DualStackNoUpgrade featureset #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reasoning makes sense to me. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@danwinship: This pull request references Bugzilla bug 2097832, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@danwinship: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@danwinship: All pull requests linked via external trackers have merged: Bugzilla bug 2097832 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This was removed in openshift/api#1201 so this follws suite.
This was removed in openshift/api#1201 so this follws suite.
This was removed in openshift/api#1201 so this follws suite.
This was removed in openshift/api#1201 so this follws suite.
This was removed in openshift/api#1201 so this follws suite.
This was removed in openshift/api#1201 so this follws suite.
This was removed in openshift/api#1201 so this follws suite.
The FeatureSet has been unnecessary for several releases, but never got removed.
Note that there is no reason to keep it around for backward compatibility, because it blocks upgrades, so upgrading users cannot possibly have it defined. Right?