Skip to content

Conversation

@danwinship
Copy link
Contributor

The FeatureSet has been unnecessary for several releases, but never got removed.

Note that there is no reason to keep it around for backward compatibility, because it blocks upgrades, so upgrading users cannot possibly have it defined. Right?

@openshift-ci openshift-ci bot requested review from deads2k and mfojtik May 23, 2022 16:15
@deads2k
Copy link
Contributor

deads2k commented Jun 16, 2022

Note that there is no reason to keep it around for backward compatibility, because it blocks upgrades, so upgrading users cannot possibly have it defined. Right?

This reasoning makes sense to me.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2022
@danwinship danwinship changed the title Drop IPv6DualStackNoUpgrade featureset Bug 2097832: Drop IPv6DualStackNoUpgrade featureset Jun 16, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2022

@danwinship: This pull request references Bugzilla bug 2097832, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

Bug 2097832: Drop IPv6DualStackNoUpgrade featureset

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from anuragthehatter June 16, 2022 16:29
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2022

@danwinship: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 689617d into openshift:master Jun 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2022

@danwinship: All pull requests linked via external trackers have merged:

Bugzilla bug 2097832 has been moved to the MODIFIED state.

In response to this:

Bug 2097832: Drop IPv6DualStackNoUpgrade featureset

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship danwinship deleted the ipv6-feature branch June 17, 2022 13:03
soltysh added a commit to soltysh/library-go that referenced this pull request Aug 16, 2022
This was removed in openshift/api#1201
so this follws suite.
soltysh added a commit to soltysh/library-go that referenced this pull request Aug 17, 2022
This was removed in openshift/api#1201
so this follws suite.
soltysh added a commit to soltysh/library-go that referenced this pull request Aug 30, 2022
This was removed in openshift/api#1201
so this follws suite.
soltysh added a commit to soltysh/library-go that referenced this pull request Aug 30, 2022
This was removed in openshift/api#1201
so this follws suite.
soltysh added a commit to soltysh/library-go that referenced this pull request Aug 31, 2022
This was removed in openshift/api#1201
so this follws suite.
soltysh added a commit to soltysh/library-go that referenced this pull request Aug 31, 2022
This was removed in openshift/api#1201
so this follws suite.
soltysh added a commit to soltysh/library-go that referenced this pull request Aug 31, 2022
This was removed in openshift/api#1201
so this follws suite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants