Skip to content

SO-112: To Install helmcharts through Samples operator #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

SO-112: To Install helmcharts through Samples operator #1517

wants to merge 6 commits into from

Conversation

fbm3307
Copy link
Contributor

@fbm3307 fbm3307 commented Jul 5, 2023 •
edited
Loading

This PR is to update the Cluster Samples Operator CRD to have the Helmchart List . This is Part of Samples operator Downsizing Phase-2, where the S2i Sample helmcharts can be installed via CSO.
Refernce -SO-112

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2023

Hello @fbm3307! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 5, 2023
@openshift-ci openshift-ci bot requested review from deads2k and mfojtik July 5, 2023 05:42
@fbm3307
Copy link
Contributor Author

fbm3307 commented Jul 5, 2023

/assign @dperaza4dustbit

@fbm3307 fbm3307 marked this pull request as draft July 5, 2023 11:06
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2023
@fbm3307 fbm3307 changed the title To Install helmcharts through Samples operator SO-102: To Install helmcharts through Samples operator Jul 20, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 20, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 20, 2023 •
edited by openshift-ci bot
Loading

@fbm3307: This pull request references SO-102 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 18, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2023
@fbm3307
Copy link
Contributor Author

fbm3307 commented Oct 19, 2023

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 19, 2023
@fbm3307
Copy link
Contributor Author

fbm3307 commented Oct 19, 2023

/lifecycle frozen

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

@fbm3307: The lifecycle/frozen label cannot be applied to Pull Requests.

In response to this:

/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fbm3307 fbm3307 marked this pull request as ready for review October 23, 2023 06:20
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2023
@openshift-ci openshift-ci bot requested a review from derekwaynecarr October 23, 2023 06:21
@fbm3307
To Install helmcharts through Samples operator
6728adf 
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@fbm3307
added helm config
99f6d12 
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@fbm3307
adding namespace for cso helm
e296808 
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@fbm3307
Changing the helm name
c425d39 
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@fbm3307
Updating the PR
6ece419 
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2023
@fbm3307 fbm3307 changed the title SO-102: To Install helmcharts through Samples operator SO-112: To Install helmcharts through Samples operator Oct 23, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 23, 2023 •
edited by openshift-ci bot
Loading

@fbm3307: This pull request references SO-112 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fbm3307
Copy link
Contributor Author

fbm3307 commented Oct 23, 2023

/assign @bparees

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 23, 2023 •
edited by openshift-ci bot
Loading

@fbm3307: This pull request references SO-112 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This PR is to update the Cluster Samples Operator CRD to have the Helmchart List . This is Part of Samples operator Downsizing Phase-2, where the S2i Sample helmcharts can be installed via CSO.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 23, 2023 •
edited by openshift-ci bot
Loading

@fbm3307: This pull request references SO-112 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This PR is to update the Cluster Samples Operator CRD to have the Helmchart List . This is Part of Samples operator Downsizing Phase-2, where the S2i Sample helmcharts can be installed via CSO.
Refernce -SO-112

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fbm3307
Fixing the schema
3e119fb 
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fbm3307
Once this PR has been reviewed and has the lgtm label, please ask for approval from bparees. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

@fbm3307: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-crd-schema 3e119fb link true /test verify-crd-schema
ci/prow/verify 3e119fb link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fbm3307
Copy link
Contributor Author

fbm3307 commented Oct 23, 2023

/unassign @bparees

bparees
bparees reviewed Oct 23, 2023
View reviewed changes
samples/v1/types_config.go

Namespace string `json:"namespace,omitempty"`

ReleaseName string `json:"releaseName,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

godoc these fields please. Also is there any validation we can put in place?

should these be required fields?

@fbm3307
Copy link
Contributor Author

fbm3307 commented Oct 25, 2023

closing this in favor of #1636
as this PR is very old and it is causing problems in testcases

@fbm3307 fbm3307 closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees bparees left review comments

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@dperaza4dustbit dperaza4dustbit

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fbm3307 @openshift-ci-robot @openshift-bot @bparees @dperaza4dustbit @openshift-merge-robot