Skip to content

NO-JIRA: New rules about CO's conditions #2469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2025
Merged

NO-JIRA: New rules about CO's conditions #2469

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75e8efa
NO-JIRA: New rules about CO's Degraded and Available conditions
hongkailiu Sep 5, 2025
5d8d667
A New rule about CO's update duration
hongkailiu Sep 5, 2025
0aed54e
Add more details about the Progressing condition
hongkailiu Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions config/v1/types_cluster_operator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,15 +154,21 @@ const (
// is functional and available in the cluster. Available=False means at least
// part of the component is non-functional, and that the condition requires
// immediate administrator intervention.
// A component must not report Available=False during the course of a normal upgrade.
OperatorAvailable ClusterStatusConditionType = "Available"

// Progressing indicates that the component (operator and all configured operands)
// is actively rolling out new code, propagating config changes, or otherwise
// is actively rolling out new code, propagating config changes (e.g, a version change), or otherwise
// moving from one steady state to another. Operators should not report
// progressing when they are reconciling (without action) a previously known
// state. If the observed cluster state has changed and the component is
// reacting to it (scaling up for instance), Progressing should become true
// Progressing when they are reconciling (without action) a previously known
// state. Operators should not report Progressing only because DaemonSets owned by them
// are adjusting to a new node from cluster scaleup or a node rebooting from cluster upgrade.
// If the observed cluster state has changed and the component is
// reacting to it (updated proxy configuration for instance), Progressing should become true
// since it is moving from one steady state to another.
// A component in a cluster with less than 250 nodes must complete a version
// change within a limited period of time: 90 minutes for Machine Config Operator and 20 minutes for others.
// Machine Config Operator is given more time as it needs to restart control plane nodes.
OperatorProgressing ClusterStatusConditionType = "Progressing"

// Degraded indicates that the component (operator and all configured operands)
Expand All @@ -175,7 +181,7 @@ const (
// Degraded because it may have a lower quality of service. A component may be
// Progressing but not Degraded because the transition from one state to
// another does not persist over a long enough period to report Degraded. A
// component should not report Degraded during the course of a normal upgrade.
// component must not report Degraded during the course of a normal upgrade.
// A component may report Degraded in response to a persistent infrastructure
// failure that requires eventual administrator intervention. For example, if
// a control plane host is unhealthy and must be replaced. A component should
Expand Down