Skip to content

[release-4.20] OCPBUGS-65481: config/v1/types_cluster_version: Tighten force and rollback warnings #2581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-4.20
Choose a base branch
from
Open

[release-4.20] OCPBUGS-65481: config/v1/types_cluster_version: Tighten force and rollback warnings #2581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions config/v1/types_cluster_version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,10 @@ type ClusterVersionSpec struct {
//
// If an upgrade fails the operator will halt and report status
// about the failing component. Setting the desired update value back to
// the previous version will cause a rollback to be attempted. Not all
// rollbacks will succeed.
// the previous version will cause a rollback to be attempted if the
// previous version is within the current minor version. Not all
// rollbacks will succeed, and some may unrecoverably break the
// cluster.
//
// +optional
DesiredUpdate *Update `json:"desiredUpdate,omitempty"`
Expand Down Expand Up @@ -718,9 +720,13 @@ type Update struct {
Image string `json:"image"`

// force allows an administrator to update to an image that has failed
// verification or upgradeable checks. This option should only
// be used when the authenticity of the provided image has been verified out
// of band because the provided image will run with full administrative access
// verification or upgradeable checks that are designed to keep your
// cluster safe. Only use this if:
// * you are testing unsigned release images in short-lived test clusters or
// * you are working around a known bug in the cluster-version
// operator and you have verified the authenticity of the provided
// image yourself.
// The provided image will run with full administrative access
// to the cluster. Do not use this flag with images that comes from unknown
// or potentially malicious sources.
//
Expand Down
16 changes: 11 additions & 5 deletions ...rd-manifests/0000_00_cluster-version-operator_01_clusterversions-CustomNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,10 @@ spec:

If an upgrade fails the operator will halt and report status
about the failing component. Setting the desired update value back to
the previous version will cause a rollback to be attempted. Not all
rollbacks will succeed.
the previous version will cause a rollback to be attempted if the
previous version is within the current minor version. Not all
rollbacks will succeed, and some may unrecoverably break the
cluster.
properties:
architecture:
description: |-
Expand All @@ -171,9 +173,13 @@ spec:
force:
description: |-
force allows an administrator to update to an image that has failed
verification or upgradeable checks. This option should only
be used when the authenticity of the provided image has been verified out
of band because the provided image will run with full administrative access
verification or upgradeable checks that are designed to keep your
cluster safe. Only use this if:
* you are testing unsigned release images in short-lived test clusters or
* you are working around a known bug in the cluster-version
operator and you have verified the authenticity of the provided
image yourself.
The provided image will run with full administrative access
to the cluster. Do not use this flag with images that comes from unknown
or potentially malicious sources.
type: boolean
Expand Down
16 changes: 11 additions & 5 deletions ...erated.crd-manifests/0000_00_cluster-version-operator_01_clusterversions-Default.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,10 @@ spec:

If an upgrade fails the operator will halt and report status
about the failing component. Setting the desired update value back to
the previous version will cause a rollback to be attempted. Not all
rollbacks will succeed.
the previous version will cause a rollback to be attempted if the
previous version is within the current minor version. Not all
rollbacks will succeed, and some may unrecoverably break the
cluster.
properties:
architecture:
description: |-
Expand All @@ -171,9 +173,13 @@ spec:
force:
description: |-
force allows an administrator to update to an image that has failed
verification or upgradeable checks. This option should only
be used when the authenticity of the provided image has been verified out
of band because the provided image will run with full administrative access
verification or upgradeable checks that are designed to keep your
cluster safe. Only use this if:
* you are testing unsigned release images in short-lived test clusters or
* you are working around a known bug in the cluster-version
operator and you have verified the authenticity of the provided
image yourself.
The provided image will run with full administrative access
to the cluster. Do not use this flag with images that comes from unknown
or potentially malicious sources.
type: boolean
Expand Down
16 changes: 11 additions & 5 deletions ...anifests/0000_00_cluster-version-operator_01_clusterversions-DevPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,10 @@ spec:

If an upgrade fails the operator will halt and report status
about the failing component. Setting the desired update value back to
the previous version will cause a rollback to be attempted. Not all
rollbacks will succeed.
the previous version will cause a rollback to be attempted if the
previous version is within the current minor version. Not all
rollbacks will succeed, and some may unrecoverably break the
cluster.
properties:
architecture:
description: |-
Expand All @@ -171,9 +173,13 @@ spec:
force:
description: |-
force allows an administrator to update to an image that has failed
verification or upgradeable checks. This option should only
be used when the authenticity of the provided image has been verified out
of band because the provided image will run with full administrative access
verification or upgradeable checks that are designed to keep your
cluster safe. Only use this if:
* you are testing unsigned release images in short-lived test clusters or
* you are working around a known bug in the cluster-version
operator and you have verified the authenticity of the provided
image yourself.
The provided image will run with full administrative access
to the cluster. Do not use this flag with images that comes from unknown
or potentially malicious sources.
type: boolean
Expand Down
16 changes: 11 additions & 5 deletions ...nifests/0000_00_cluster-version-operator_01_clusterversions-TechPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,10 @@ spec:

If an upgrade fails the operator will halt and report status
about the failing component. Setting the desired update value back to
the previous version will cause a rollback to be attempted. Not all
rollbacks will succeed.
the previous version will cause a rollback to be attempted if the
previous version is within the current minor version. Not all
rollbacks will succeed, and some may unrecoverably break the
cluster.
properties:
architecture:
description: |-
Expand All @@ -171,9 +173,13 @@ spec:
force:
description: |-
force allows an administrator to update to an image that has failed
verification or upgradeable checks. This option should only
be used when the authenticity of the provided image has been verified out
of band because the provided image will run with full administrative access
verification or upgradeable checks that are designed to keep your
cluster safe. Only use this if:
* you are testing unsigned release images in short-lived test clusters or
* you are working around a known bug in the cluster-version
operator and you have verified the authenticity of the provided
image yourself.
The provided image will run with full administrative access
to the cluster. Do not use this flag with images that comes from unknown
or potentially malicious sources.
type: boolean
Expand Down
16 changes: 11 additions & 5 deletions ...generated.featuregated-crd-manifests/clusterversions.config.openshift.io/AAA_ungated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,10 @@ spec:

If an upgrade fails the operator will halt and report status
about the failing component. Setting the desired update value back to
the previous version will cause a rollback to be attempted. Not all
rollbacks will succeed.
the previous version will cause a rollback to be attempted if the
previous version is within the current minor version. Not all
rollbacks will succeed, and some may unrecoverably break the
cluster.
properties:
architecture:
description: |-
Expand All @@ -173,9 +175,13 @@ spec:
force:
description: |-
force allows an administrator to update to an image that has failed
verification or upgradeable checks. This option should only
be used when the authenticity of the provided image has been verified out
of band because the provided image will run with full administrative access
verification or upgradeable checks that are designed to keep your
cluster safe. Only use this if:
* you are testing unsigned release images in short-lived test clusters or
* you are working around a known bug in the cluster-version
operator and you have verified the authenticity of the provided
image yourself.
The provided image will run with full administrative access
to the cluster. Do not use this flag with images that comes from unknown
or potentially malicious sources.
type: boolean
Expand Down
16 changes: 11 additions & 5 deletions ...featuregated-crd-manifests/clusterversions.config.openshift.io/ImageStreamImportMode.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,10 @@ spec:

If an upgrade fails the operator will halt and report status
about the failing component. Setting the desired update value back to
the previous version will cause a rollback to be attempted. Not all
rollbacks will succeed.
the previous version will cause a rollback to be attempted if the
previous version is within the current minor version. Not all
rollbacks will succeed, and some may unrecoverably break the
cluster.
properties:
architecture:
description: |-
Expand All @@ -173,9 +175,13 @@ spec:
force:
description: |-
force allows an administrator to update to an image that has failed
verification or upgradeable checks. This option should only
be used when the authenticity of the provided image has been verified out
of band because the provided image will run with full administrative access
verification or upgradeable checks that are designed to keep your
cluster safe. Only use this if:
* you are testing unsigned release images in short-lived test clusters or
* you are working around a known bug in the cluster-version
operator and you have verified the authenticity of the provided
image yourself.
The provided image will run with full administrative access
to the cluster. Do not use this flag with images that comes from unknown
or potentially malicious sources.
type: boolean
Expand Down
16 changes: 11 additions & 5 deletions ...rated.featuregated-crd-manifests/clusterversions.config.openshift.io/SignatureStores.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,10 @@ spec:

If an upgrade fails the operator will halt and report status
about the failing component. Setting the desired update value back to
the previous version will cause a rollback to be attempted. Not all
rollbacks will succeed.
the previous version will cause a rollback to be attempted if the
previous version is within the current minor version. Not all
rollbacks will succeed, and some may unrecoverably break the
cluster.
properties:
architecture:
description: |-
Expand All @@ -173,9 +175,13 @@ spec:
force:
description: |-
force allows an administrator to update to an image that has failed
verification or upgradeable checks. This option should only
be used when the authenticity of the provided image has been verified out
of band because the provided image will run with full administrative access
verification or upgradeable checks that are designed to keep your
cluster safe. Only use this if:
* you are testing unsigned release images in short-lived test clusters or
* you are working around a known bug in the cluster-version
operator and you have verified the authenticity of the provided
image yourself.
The provided image will run with full administrative access
to the cluster. Do not use this flag with images that comes from unknown
or potentially malicious sources.
type: boolean
Expand Down
Loading