Move ProfileCustomizations under a new GA gate #2590
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| apiVersion: apiextensions.k8s.io/v1 # Hack because controller-gen complains if we don't have this | ||
| name: "Scheduler" | ||
| crdName: schedulers.config.openshift.io | ||
| featureGates: | ||
| - HyperShiftOnlyDynamicResourceAllocation | ||
| tests: | ||
| onCreate: | ||
| - name: Should be able to create a minimal Scheduler | ||
| initial: | | ||
| apiVersion: config.openshift.io/v1 | ||
| kind: Scheduler | ||
| spec: {} # No spec is required for a Scheduler | ||
| expected: | | ||
| apiVersion: config.openshift.io/v1 | ||
| kind: Scheduler | ||
| spec: {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,143 @@ | ||
| apiVersion: apiextensions.k8s.io/v1 | ||
| kind: CustomResourceDefinition | ||
| metadata: | ||
| annotations: | ||
| api-approved.openshift.io: https://github.com/openshift/api/pull/470 | ||
| api.openshift.io/merged-by-featuregates: "true" | ||
| include.release.openshift.io/ibm-cloud-managed: "true" | ||
| release.openshift.io/bootstrap-required: "true" | ||
| name: schedulers.config.openshift.io | ||
| spec: | ||
| group: config.openshift.io | ||
| names: | ||
| kind: Scheduler | ||
| listKind: SchedulerList | ||
| plural: schedulers | ||
| singular: scheduler | ||
| scope: Cluster | ||
| versions: | ||
| - name: v1 | ||
| schema: | ||
| openAPIV3Schema: | ||
| description: |- | ||
| Scheduler holds cluster-wide config information to run the Kubernetes Scheduler | ||
| and influence its placement decisions. The canonical name for this config is `cluster`. | ||
|
|
||
| Compatibility level 1: Stable within a major release for a minimum of 12 months or 3 minor releases (whichever is longer). | ||
| properties: | ||
| apiVersion: | ||
| description: |- | ||
| APIVersion defines the versioned schema of this representation of an object. | ||
| Servers should convert recognized schemas to the latest internal value, and | ||
| may reject unrecognized values. | ||
| More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources | ||
| type: string | ||
| kind: | ||
| description: |- | ||
| Kind is a string value representing the REST resource this object represents. | ||
| Servers may infer this from the endpoint the client submits requests to. | ||
| Cannot be updated. | ||
| In CamelCase. | ||
| More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds | ||
| type: string | ||
| metadata: | ||
| type: object | ||
| spec: | ||
| description: spec holds user settable values for configuration | ||
| properties: | ||
| defaultNodeSelector: | ||
| description: |- | ||
| defaultNodeSelector helps set the cluster-wide default node selector to | ||
| restrict pod placement to specific nodes. This is applied to the pods | ||
| created in all namespaces and creates an intersection with any existing | ||
| nodeSelectors already set on a pod, additionally constraining that pod's selector. | ||
| For example, | ||
| defaultNodeSelector: "type=user-node,region=east" would set nodeSelector | ||
| field in pod spec to "type=user-node,region=east" to all pods created | ||
| in all namespaces. Namespaces having project-wide node selectors won't be | ||
| impacted even if this field is set. This adds an annotation section to | ||
| the namespace. | ||
| For example, if a new namespace is created with | ||
| node-selector='type=user-node,region=east', | ||
| the annotation openshift.io/node-selector: type=user-node,region=east | ||
| gets added to the project. When the openshift.io/node-selector annotation | ||
| is set on the project the value is used in preference to the value we are setting | ||
| for defaultNodeSelector field. | ||
| For instance, | ||
| openshift.io/node-selector: "type=user-node,region=west" means | ||
| that the default of "type=user-node,region=east" set in defaultNodeSelector | ||
| would not be applied. | ||
| type: string | ||
| mastersSchedulable: | ||
| description: |- | ||
| mastersSchedulable allows masters nodes to be schedulable. When this flag is | ||
| turned on, all the master nodes in the cluster will be made schedulable, | ||
| so that workload pods can run on them. The default value for this field is false, | ||
| meaning none of the master nodes are schedulable. | ||
| Important Note: Once the workload pods start running on the master nodes, | ||
| extreme care must be taken to ensure that cluster-critical control plane components | ||
| are not impacted. | ||
| Please turn on this field after doing due diligence. | ||
| type: boolean | ||
| policy: | ||
| description: |- | ||
| DEPRECATED: the scheduler Policy API has been deprecated and will be removed in a future release. | ||
| policy is a reference to a ConfigMap containing scheduler policy which has | ||
| user specified predicates and priorities. If this ConfigMap is not available | ||
| scheduler will default to use DefaultAlgorithmProvider. | ||
| The namespace for this configmap is openshift-config. | ||
| properties: | ||
| name: | ||
| description: name is the metadata.name of the referenced config | ||
| map | ||
| type: string | ||
| required: | ||
| - name | ||
| type: object | ||
| profile: | ||
| description: |- | ||
| profile sets which scheduling profile should be set in order to configure scheduling | ||
| decisions for new pods. | ||
|
|
||
| Valid values are "LowNodeUtilization", "HighNodeUtilization", "NoScoring" | ||
| Defaults to "LowNodeUtilization" | ||
| enum: | ||
| - "" | ||
| - LowNodeUtilization | ||
| - HighNodeUtilization | ||
| - NoScoring | ||
| type: string | ||
| profileCustomizations: | ||
| description: |- | ||
| profileCustomizations contains configuration for modifying the default behavior of existing scheduler profiles. | ||
| Deprecated: no longer needed, since DRA is GA starting with 4.21, and | ||
| is enabled by' default in the cluster, this field will be removed in 4.24. | ||
|
Comment on lines
+111
to
+114
There was a problem hiding this comment. Fix typo in deprecation notice. Line 114 contains profileCustomizations:
description: |-
profileCustomizations contains configuration for modifying the default behavior of existing scheduler profiles.
Deprecated: no longer needed, since DRA is GA starting with 4.21, and
- is enabled by' default in the cluster, this field will be removed in 4.24.
+ is enabled by default in the cluster, this field will be removed in 4.24.
🤖 Prompt for AI Agents |
||
| properties: | ||
| dynamicResourceAllocation: | ||
| description: |- | ||
| dynamicResourceAllocation allows to enable or disable dynamic resource allocation within the scheduler. | ||
| Dynamic resource allocation is an API for requesting and sharing resources between pods and containers inside a pod. | ||
| Third-party resource drivers are responsible for tracking and allocating resources. | ||
| Different kinds of resources support arbitrary parameters for defining requirements and initialization. | ||
| Valid values are Enabled, Disabled and omitted. | ||
| When omitted, this means no opinion and the platform is left to choose a reasonable default, | ||
| which is subject to change over time. | ||
| The current default is Disabled. | ||
| enum: | ||
| - "" | ||
| - Enabled | ||
| - Disabled | ||
| type: string | ||
| type: object | ||
| type: object | ||
| status: | ||
| description: status holds observed values from the cluster. They may not | ||
| be overridden. | ||
| type: object | ||
| required: | ||
| - spec | ||
| type: object | ||
| served: true | ||
| storage: true | ||
| subresources: | ||
| status: {} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it would make the most sense to merge this in keeping the DRA gate in place so that we can avoid an accidental backwards-incompatible change in the hypershift APIs until we explicitly change the gates that are used in the hypershift repository?